Skip to content

Increase test coverage#222

Merged
ahcorde merged 5 commits intorollingfrom
ahcorde/rolling/increate_test_coverage
Mar 12, 2026
Merged

Increase test coverage#222
ahcorde merged 5 commits intorollingfrom
ahcorde/rolling/increate_test_coverage

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 9, 2026

Description

Increased test coverage

Did you use Generative AI?

Claude Sonnet 4.6

@ahcorde
Increase test coverage
85ce095 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Mar 9, 2026
mjcarroll
mjcarroll reviewed Mar 9, 2026
View reviewed changes
Comment thread test/test_asserts.cpp
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 9, 2026

Pulls: #222
Gist: https://gist.githubusercontent.com/ahcorde/efee2093f1ba7cfbab357cad109a3ef3/raw/daf76a5dbe2a10d83c44d43996f002799918d67b/ros2.repos
BUILD args: --packages-above-and-dependencies rcpputils
TEST args: --packages-above rcpputils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18416

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya requested changes Mar 9, 2026
View reviewed changes
Comment thread test/test_env.cpp Outdated
Comment thread test/test_env.cpp Outdated
Comment thread test/test_process.cpp Outdated
@ahcorde
review feedback
21a6637 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from fujitatomoya March 10, 2026 21:57
@ahcorde
Fix windows
394b063 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 10, 2026 •
edited
Loading

Pulls: #222
Gist: https://gist.githubusercontent.com/ahcorde/55536f8da74c322e7f03f2931409cfae/raw/daf76a5dbe2a10d83c44d43996f002799918d67b/ros2.repos
BUILD args: --packages-above-and-dependencies rcpputils
TEST args: --packages-above rcpputils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18428

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Fix windwos
28102f5 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2026

Pulls: #222
Gist: https://gist.githubusercontent.com/ahcorde/2d5239d34a04677f56d55c77cebfef41/raw/daf76a5dbe2a10d83c44d43996f002799918d67b/ros2.repos
BUILD args: --packages-above-and-dependencies rcpputils
TEST args: --packages-above rcpputils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18442

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
make linters happy
21f9da6 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 12, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 112803c into rolling Mar 12, 2026
3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/increate_test_coverage branch March 12, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @mjcarroll @fujitatomoya