Skip to content

Comments

Added rosidl_generator_rs (Humble)#33

Merged
ahcorde merged 1 commit intoros2:humblefrom
esteve:humble-add-rosidl_generator_rs
Feb 23, 2026
Merged

Added rosidl_generator_rs (Humble)#33
ahcorde merged 1 commit intoros2:humblefrom
esteve:humble-add-rosidl_generator_rs

Conversation

@esteve
Copy link
Member

@esteve esteve commented Jan 21, 2026

This PR is a backport of ros2/rosidl_core#9 for Humble

Signed-off-by: Esteve Fernandez <esteve@apache.org>
@esteve
Copy link
Member Author

esteve commented Feb 19, 2026

@ahcorde this one should also pass CI now with rosidl_generator_rs in rosdistro and in the ros2.repos file.

@ahcorde
Copy link
Contributor

ahcorde commented Feb 19, 2026

Pulls: #33
Gist: https://gist.githubusercontent.com/ahcorde/16bdafc309812a0de126dd43a01d7b1e/raw/f65f99009b0850eab55176e515e98a29e58e500d/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_default_generators
TEST args: --packages-above rosidl_default_generators
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18255

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@esteve
Copy link
Member Author

esteve commented Feb 19, 2026

@ahcorde the linux build is failling, it doesn't seem related to these changes, but I don't know what the issue is.

@esteve esteve force-pushed the humble-add-rosidl_generator_rs branch from a7e2465 to c855b71 Compare February 19, 2026 15:00
@esteve
Copy link
Member Author

esteve commented Feb 19, 2026

Linux-rhel is failing because the generator uses .removesuffix, which was approved for Python 3.9 (https://peps.python.org/pep-0616/), but RHEL ships with Python 3.6, I can come up with a workaround.

The Linux aarch build seems to be running fine, the error in the Linux amd64 is unrelated.

@ahcorde
Copy link
Contributor

ahcorde commented Feb 19, 2026

Pulls: #33
Gist: https://gist.githubusercontent.com/ahcorde/f64b037caed19b743e8015cfede80947/raw/f65f99009b0850eab55176e515e98a29e58e500d/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_default_generators
TEST args: --packages-above rosidl_default_generators
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18263

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Feb 20, 2026

Linux-rhel is failing because the generator uses .removesuffix, which was approved for Python 3.9 (https://peps.python.org/pep-0616/), but RHEL ships with Python 3.6, I can come up with a workaround.

The Linux aarch build seems to be running fine, the error in the Linux amd64 is unrelated.

@esteve please, can you open a PR fixing this for humble ? CI is broken for RHEL

@esteve
Copy link
Member Author

esteve commented Feb 20, 2026

@ahcorde I've pushed ros2-rust/rosidl_rust#17 which should fix the issue for RHEL 8, if you trigger another build, CI should pick up the fix.

I'll make a release to the buildfarm shortly.

Edit: actual fix in ros2-rust/rosidl_rust#18

@ahcorde
Copy link
Contributor

ahcorde commented Feb 20, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@esteve
Copy link
Member Author

esteve commented Feb 20, 2026

@ahcorde I've submitted the following PRs to rosdistro:

ros/rosdistro#49926 (Humble)

ros/rosdistro#49927 (Jazzy)

ros/rosdistro#49928 (Kilted)

ros/rosdistro#49929 (Rolling)

@ahcorde ahcorde merged commit 3a24554 into ros2:humble Feb 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants