Skip to content

remove python_cmake_module as it has been migrated to its own repository#87

Merged
wjwwood merged 1 commit intomasterfrom
remove_python_cmake_module
Sep 23, 2019
Merged

remove python_cmake_module as it has been migrated to its own repository#87
wjwwood merged 1 commit intomasterfrom
remove_python_cmake_module

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Sep 19, 2019

See the new repository here: https://github.com/ros2/python_cmake_module

ros2/ros2#781 is also required.

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Sep 19, 2019
@wjwwood wjwwood self-assigned this Sep 19, 2019
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Sep 19, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich
Copy link
Copy Markdown
Member

It looks like CI is iterating on the package names before checking out the test branch which is causing failures due to the duplicate package name.

@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Sep 19, 2019

Actually I had the wrong repository in place in the ros2/ros2 pr. New CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Sep 19, 2019

Mistakes were made, this one should work hopefully:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 4407304 into master Sep 23, 2019
@delete-merged-branch delete-merged-branch Bot deleted the remove_python_cmake_module branch September 23, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants