Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct sros2 cli test folder location #83

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Correct sros2 cli test folder location #83

merged 2 commits into from
Feb 22, 2019

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Feb 21, 2019

I'm not sure how only these rename and rm commits got dropped from my rebasing of #72 .
These are the only changes that had rebase differ from the PR commits prior to rebasing.

@ruffsl
Update test folder location
d1b24c8 
fixing incomplete rebase from #72
@ruffsl
Remove old yaml profile examples
df6381a 
fixing incomplete rebase from #72
@ruffsl ruffsl added the in progress Actively being worked on (Kanban column) label Feb 21, 2019
@ruffsl ruffsl added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
@mikaelarguedas
Copy link
Member

lgtm, tests work for me with that branch 👍

Will there be a document replacing policy_definition.md?

@ruffsl
Copy link
Member Author

ruffsl commented Feb 21, 2019

Will there be a document replacing policy_definition.md

I won't have time until the end of this month, but feel free to take a stab at it. Having a second person combe through the schema and templates would help in case I missed a corner case.

@mikaelarguedas
Copy link
Member

I won't have time until the end of this month, but feel free to take a stab at it.

Sounds good, I'll see if I find time to look into it.
Do you think this document is a requirement for the xml based policy to be part of the next Crystal patch release?

@ruffsl
Copy link
Member Author

ruffsl commented Feb 21, 2019

Do you think this document is a requirement for the xml based policy to be part of the next Crystal patch release?

I'm not sure it would be a requirement, given the examples in the test folder are a bit self explanatory, but something short explaining the features of the namespacing parameters and permission flags might be helpful.

https://github.com/ros2/sros2/blob/master/SROS2_Linux.md#access-control

@mjcarroll mjcarroll merged commit d419f7b into master Feb 22, 2019
@mjcarroll mjcarroll deleted the xml_profile branch February 22, 2019 16:10
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Feb 22, 2019
mjcarroll added a commit that referenced this pull request Mar 8, 2019
@mjcarroll
[crystal-backport] Backport XML and XSLT functionality (#93)
aafc86d 
* Correct sros2 cli test folder location (#83)

* Update test folder location
fixing incomplete rebase from #72

* Remove old yaml profile examples
fixing incomplete rebase from #72

* add reference to schema in generated permission files (#84)

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* Add missing attributes to test permissions XML file

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* fix status print to match commands invoked

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* Fix bug preventing generate_policy verb from working with publishers and services

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add CMake lint test to sros2_cmake (#90)

Fixed lint errors accordingly.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@mjcarroll mjcarroll mentioned this pull request Mar 11, 2019
Merged
@nuclearsandwich nuclearsandwich mentioned this pull request Mar 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruffsl @mikaelarguedas @mjcarroll