RD-2370: TVEC updates#130
Merged
guruxu merged 5 commits intorosette-api:masterfrom Jul 30, 2018
Merged
Conversation
peblair
force-pushed
the
rd-2370-tvec-updates
branch
from
53a50a3 to
f00fa15
Compare
peblair
force-pushed
the
rd-2370-tvec-updates
branch
from
f00fa15 to
b44289c
Compare
guruxu
reviewed
Jul 30, 2018
| public class TextEmbeddingOptions extends Options { | ||
|
|
||
| /** | ||
| * @return whether embeddings should be returned for each token |
Contributor
There was a problem hiding this comment.
add in addition to the whole document to avoid possible confusion?
guruxu
reviewed
Jul 30, 2018
| * @return the document embedding vector as a list | ||
| */ | ||
| private final List<Double> embedding; | ||
| private final List<Double> documentEmbedding; |
Contributor
There was a problem hiding this comment.
Aren't we deprecating the old one?
Contributor
Author
There was a problem hiding this comment.
I'm double-checking with Hannah to be sure, but I think the plan is to just make the change (since TVEC is still in "Labs")
Contributor
Author
There was a problem hiding this comment.
Alright, Hannah just confirmed that we can go ahead and just rename the field. She will make sure that the appropriate customers are notified about the change.
guruxu
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the TVEC API model to support per-token embedding responses.