Rlpnc 7501 record similarity left and right objects: correct deserialization #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iredpath
requested changes
Apr 16, 2024
Contributor
iredpath
left a comment
iredpath
left a comment
There was a problem hiding this comment.
Other items based on files not included in the current changes (since we're already here fixing a bug):
scoreinRecordSimilarityResultneeds to be aDouble, not adoubleRecordSimilarityExplainInfoshould be annotated with@JsonInclude(JsonInclude.Include.NON_NULL)- We're in this position in the first place because the original code wasn't tested. Please add a unit test! I'll attach the one I created while simultaneously working through this issue to the JIRA ticket (I forgot that your team was already handling this fix)
This should not replace any code review/verification by someone on the Nomina team
...te/apimodel/jackson/recordsimilaritydeserializers/RecordSimilarityDeserializerUtilities.java
Show resolved
Hide resolved
...tte/apimodel/jackson/recordsimilaritydeserializers/RecordSimilarityResponseDeserializer.java
Show resolved
Hide resolved
iredpath
approved these changes
Apr 17, 2024
Contributor
iredpath
left a comment
iredpath
left a comment
There was a problem hiding this comment.
LGTM, one or two tiny nitpicks that are going to be addressed in future bindings updates this quarter so no need to get into them now
Contributor
|
I'd like to see the sonar results, but jenkins is failing with a nexus issue currently. Otherwise LGTM |
Contributor
asoosprecognox
approved these changes
Apr 19, 2024
asoosprecognox
requested changes
Apr 19, 2024
Contributor
Author
|
Sonar smells fixed |
asoosprecognox
approved these changes
Apr 19, 2024
asoosprecognox
deleted the
rlpnc-7501-record-similarity-left-and-right-correct-deserialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.