Conversation
iredpath
reviewed
Apr 18, 2024
Contributor
|
Review is all good on the names side |
Contributor
|
@seth-mg @asoosprecognox aside from the merge conflict, does this look alright to you? If I should reach out to someone else to get this reviewed, let me know |
Contributor
|
Maybe add a scoreIfNull in the test that is a value and not just null, if that makes sense with the business logic. Otherwise it looks good if sonar is happy (no major/critical issues) after the merge conflicts are resolved |
# Conflicts: # json/src/test/java/com/basistech/rosette/apimodel/RecordSimilarityRequestTest.java
Contributor
|
@fhasanaj there's another merge conflict now after the RLPNC-7512 merge |
# Conflicts: # json/src/test/java/com/basistech/rosette/apimodel/recordsimilarity/RecordSimilarityResponseTest.java
Contributor
|
LGTM, @asoosprecognox or @seth-mg it would be great if one of you could take one more look before we merge this in |
Contributor
Author
|
@asoosprecognox or @seth-mg can we get an approval from one of you please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.