Skip to content

RCB-547 Remove hardcoded version from test #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karin-Basis merged 1 commit into from
Jan 24, 2018
Merged

RCB-547 Remove hardcoded version from test #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rosette/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,10 @@ def __del__(self):
except ReferenceError:
pass

def get_binding_version(self):
""" Return the current binding version """
return _BINDING_VERSION

def get_user_agent_string(self):
""" Return the User-Agent string """
return self.user_agent_string
Expand Down
3 changes: 1 addition & 2 deletions tests/test_rosette_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
RosetteException)

_ISPY3 = sys.version_info[0] == 3
_BINDING_VERSION = '1.8.2'


@pytest.fixture
Expand Down Expand Up @@ -138,7 +137,7 @@ def test_invalid_header(api):

def test_user_agent(api):
""" Test user agent """
value = "RosetteAPIPython/" + _BINDING_VERSION + "/" + platform.python_version()
value = "RosetteAPIPython/" + api.get_binding_version() + "/" + platform.python_version()
assert value == api.get_user_agent_string()

# Test that pinging the API is working properly
Expand Down