This closes rosjava/rosjava_core#233. Adds fix for shutting down Defa…#234
This closes rosjava/rosjava_core#233. Adds fix for shutting down Defa…#234adamantivm merged 1 commit intorosjava:indigofrom
Conversation
…ecutor ListenerGroup to prevent leak in android when activities are destroyed. Added ability to remove listener from ListenerGroup to fix android_core issue rosjava#254.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Awesome contribution. Thank you very much @stratomda. This is ready to merge as soon as the CLA bot is happy. |
|
I signed it! |
adamantivm
left a comment
adamantivm
left a comment
There was a problem hiding this comment.
making sure we don't accidentally introduce unintended changes.
build.gradle
Outdated
|
|
||
| buildscript { | ||
| apply from: "https://github.com/rosjava/rosjava_bootstrap/raw/indigo/buildscript.gradle" | ||
| apply from: "https://github.com/stratomda/rosjava_bootstrap/raw/indigo/buildscript.gradle" |
There was a problem hiding this comment.
any reason for this change? This should probably be reverted before merging, right?
There was a problem hiding this comment.
Yeah this was a left over. Sorry bout that. Feel free to revert.
There was a problem hiding this comment.
I didn't commit the package bump in the package.xml file because I don't know how the package version numbering works. Let me know when you update the package number so i can include that reference in my android_core bug (rosjava/android_core#254). Thanks. I appreciate it!
|
Reverted. And also bumped package number. Sorry for the confusion. Reject if package number doesn't follow conventions. |
|
@stratomda for some reason the @googlebot still thinks there's something wrong with the CLA. Did you sign an individual CLA or a Company CLA? Could you try to verify if anything may not have gone right with that? otherwise I can try to follow-up with Google to see what's wrong. About versioning, I prefer to bump the package version as part of the release process using standard ROS release tools. Also, I may wait for a couple more fixes or additions before pushing out a new version - unless you have a pressing need to have this one released to maven sooner than that. Bottom line, if you could revert the package version change I'd appreciate it. Again, thank you very much for your contribution here, it's very valuable. We're almost there. |
|
@stratomda besides the CLA, it was just pointed to me that the PR is going to indigo. Could you target it to kinetic instead? Or do you need to do this in indigo for any particular purpose? I would have a strong preference to focus all our efforts on kinetic instead of indigo at this point. |
|
@googlebot the CLA is signed, what's up? |
|
I had the CLA checked and verified in the Google system and it is OK to accept. |
3 participants
…ultNodeMainExecutor ListenerGroup to prevent leak in android when activities are destroyed. Added ability to remove listener from ListenerGroup to fix android_core issue #254.