Skip to content

fix: judge learner answers before tutor moves - #55

Merged
rosshd merged 2 commits into
mainfrom
fix/issue-45-answer-first
Jul 27, 2026
Merged

fix: judge learner answers before tutor moves#55
rosshd merged 2 commits into
mainfrom
fix/issue-45-answer-first

Conversation

@rosshd

@rosshd rosshd commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Closes #45

What changed

  • Judge pending-check answers before generating the tutor response.
  • Generate the next response from the learner's freshly updated state while preserving the prior question's focus and concept attribution.
  • Skip grading for navigation and unrelated turns.
  • Preserve the pending learner prompt and roll back uncommitted state if tutor generation fails.
  • Bound the pre-stream judgment call to 512 output tokens, 20 seconds, and one attempt.
  • Add focused CLI and tutor-behavior regression coverage.

Verification

  • PYTHONPATH=src make check PYTHON=../../.venv/bin/python OPENLEARN=../../.venv/bin/openlearn
  • PYTHONPATH=src make review PYTHON=../../.venv/bin/python OPENLEARN=../../.venv/bin/openlearn
  • 429 unittest tests passed, 1 skipped.
  • 533 pytest tests passed, 1 skipped, 11 deselected.
  • Ruff and smoke checks passed.

@rosshd
rosshd merged commit 2a6c684 into main Jul 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Judge learner answers before generating the tutor move

1 participant