Skip to content

fix: Restore search-based automation after rossoctl rename#33

Open
rubambiza wants to merge 1 commit into
rossoctl:mainfrom
rubambiza:fix/rossoctl-rename-search-restore
Open

fix: Restore search-based automation after rossoctl rename#33
rubambiza wants to merge 1 commit into
rossoctl:mainfrom
rubambiza:fix/rossoctl-rename-search-restore

Conversation

@rubambiza

Copy link
Copy Markdown
Contributor

Summary

GitHub issue/PR search does not follow org renames, so three search-backed code paths silently broke when kagenti became rossoctl (git and gh api calls kept working via redirect, which is why this went unnoticed):

  1. pr-review-impact.sh get_repos() — the reviewed-by search 422'd on the old repo names, so the script wrote reviewed: 0 and the impact metrics froze. Now emits rossoctl/* with the name remaps (kagentirossoctl, kagenti-extensionscortex).
  2. extract-broken-links.sh — the internal/external classifier matched only github.com/kagenti, so links under the new org were misclassified as external and stopped getting fix-PRs. Now matches both orgs ((kagenti|rossoctl)) so surviving (still-redirecting) old links stay internal; the kagenti alternative can be dropped after a docs sweep.
  3. link-health-scanner.sh — the org-wide broken-link issue search used org:kagenti, which 422'd and zeroed the dashboard's per-repo issue counts. Now uses org:rossoctl.

Scoped to the functional restore only — no cleanup of the remaining (redirect-working) kagenti references, which are tracked separately.

Verification

  • Added a rossoctl internal-link test case; full suite passes (test-extract-broken-links.sh 24/24, plus test-pr-review-impact.sh, test-pr-review-integration.sh, test-parse-diff-map.sh).
  • End-to-end: pr-review-impact.sh reviewed count restored from 0 to a live nonzero value with all activations detected; the org:rossoctl issue search returns results where org:kagenti 422s; a github.com/rossoctl/... link classifies as internal.

Part of #32. Fixes #28.

Assisted-By: Claude Code

GitHub issue/PR search does not follow org renames, so three
search-backed code paths silently broke when kagenti became rossoctl
(git and gh api calls kept working via redirect):

- pr-review-impact.sh get_repos(): reviewed-by search 422'd on the old
  repo names, freezing impact metrics at reviewed=0. Emit rossoctl/*
  with name remaps (kagenti->rossoctl, kagenti-extensions->cortex).
- extract-broken-links.sh: internal/external classifier matched only
  github.com/kagenti. Match both orgs so surviving (redirecting) old
  links stay internal; drop kagenti after a docs sweep.
- link-health-scanner.sh: org:kagenti broken-link issue search 422'd,
  zeroing the dashboard's per-repo issue counts. Use org:rossoctl.

Add a rossoctl internal-link test case. Verified end-to-end: impact
reviewed count restored to 36, org:rossoctl issue search returns
results where org:kagenti 422s.

Part of rossoctl#32.

Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
@rubambiza rubambiza self-assigned this Jul 23, 2026
@rubambiza rubambiza added the ready-for-ai-review Request automated AI code review from clawgenti label Jul 23, 2026

@clawgenti clawgenti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-file fix restoring three search-backed code paths broken by the kagentirossoctl org rename: pr-review-impact.sh repo list, extract-broken-links.sh internal-category regex (now matches both orgs for redirect continuity), and link-health-scanner.sh org-wide issue search. New test case 6b validates the rossoctl internal-link classification.

All checks pass. Ready for human review.


Reviewed by clawgenti using github:pr-review

@rubambiza rubambiza added ready-for-human-review AI review passed, ready for human reviewer and removed ready-for-ai-review Request automated AI code review from clawgenti labels Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review AI review passed, ready for human reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Restore search-based automation broken by org rename

2 participants