fix(test): register field indexer in controller test suite (#351)

[cwiklik]

Summary

• Register AgentCard .spec.targetRef.name field indexer in the controller test suite's BeforeSuite
• Replace plain client.New() with a ctrl.Manager-backed client that has the indexer registered
• Fixes the mapWorkloadToAgentCards test that fails with field label not supported: .spec.targetRef.name

Fixes #351

Root Cause

suite_test.go created a plain client.New(cfg, ...) without a ctrl.Manager. The mapWorkloadToAgentCards function queries with client.MatchingFields{".spec.targetRef.name": ...} which requires the field indexer registered by RegisterAgentCardTargetRefIndex(mgr). In production, the three controllers all register this in SetupWithManager, but the test suite skipped it.

Changes

File	What
internal/controller/suite_test.go	Create ctrl.Manager, register AgentCardTargetRefIndex, start manager, use mgr.GetClient()

Test Results

All 5 mapWorkloadToAgentCards specs pass (previously 1 failed):

Ran 5 of 163 Specs in 7.441 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 158 Skipped

Assisted-By: Claude Code

[huang195]

Fix addresses root cause of #351: test suite's client.New() bypassed ctrl.Manager, so the AgentCard.spec.targetRef.name field indexer was never registered, breaking mapWorkloadToAgentCards. This PR adds a Manager in BeforeSuite, registers the indexer, and exposes indexedClient for tests that need field-indexed queries. Existing tests stay on plain k8sClient — minimal blast radius. Dobra robota.

Areas reviewed: Go test setup
Commits: 1, signed-off ✓, Assisted-By footer ✓
CI: all 15 checks green (E2E, Integration, Unit, Lint, CodeQL, Trivy)

[huang195]

Non-blocking suggestion: after starting the manager in a goroutine, the cache-backed client from mgr.GetClient() isn't guaranteed ready. Consider adding Expect(mgr.GetCache().WaitForCacheSync(ctx)).To(BeTrue()) before assigning indexedClient — would prevent flakes if future tests query immediately after suite setup. CI is green today so not blocking.

[Ladas]

Looks good!

@huang195 one question, how did you get your agent giving Dobra robota in review? ("good work" in Czech and I guess some Slavic languages?). I know some models/agents started to use Chinese for internal thinking, to have less token usage. But I wonder what is Slavic good for, that it got in? 😄