fix: Retry incomplete HTTP responses - #348
Merged
mheffner merged 1 commit intoAug 1, 2026
Merged
Conversation
brightsparc
marked this pull request as ready for review
July 31, 2026 18:35
mheffner
approved these changes
Aug 1, 2026
mheffner
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347.
What changed
hyper::Errorvalues for whichis_incomplete_message()is true as retryable.IncompleteMessage, and verifiesRetryPolicyretries it.Why
During a staging ClickHouse load test with Rotel 0.2.2, ten turns were missing and Rotel logged permanent exporter drops with this error shape:
Three drops occurred during the affected run at 2026-07-30 00:50:45Z, 01:10:58Z, and 01:33:58Z. Rotel's retry policy already walks the error source chain, but only recognized timeouts and
ConnectError, so this transport failure bypassed the configured retry budget and immediately reachedExporting failed, dropping data.ClickHouse query and asynchronous-insert logs showed successful inserts continuously through all three windows, with
status = Ok,exception_code = 0, and no corresponding ClickHouse warning/error entries. That points to an incomplete response caused by a connection reset rather than malformed telemetry or a broad ClickHouse failure.Delivery semantics
An incomplete response is an ambiguous commit: the destination might have committed the request before the response was truncated. Retrying therefore provides at-least-once delivery and may produce duplicates unless the destination deduplicates requests. For telemetry export, that is preferable to confirmed permanent loss; stable request identity/deduplication remains a worthwhile follow-up for destinations that need stronger guarantees.
Validation
cargo fmt --all --checkcargo test -p rotel exporters::http::retry::tests— 18 passedcargo clippy -p rotel --lib --tests -- -D warnings— blocked by existing repository-wide warnings in unrelated files; this change introduces no Clippy diagnostic in the output