Use crates.io opentelemetry deps instead of git rev - #357
Merged
Conversation
opentelemetry_sdk 0.32.1 (the version fixing the flagged advisory) and opentelemetry/opentelemetry-proto 0.32.0 are all published on crates.io, and 0.32.1 already includes the 32-bit ARM portable-atomic fix (PR #3345), so the git pin to rev 284a37d9 is no longer needed. Sourcing from git kept a git-based opentelemetry_sdk in Cargo.lock, which Dependabot cannot match against its advisory DB and flagged as a false positive. The prometheus feature's fork (opentelemetry-prometheus-text-exporter) was likewise updated to registry deps so no git-sourced opentelemetry remains in the lockfile. Builds verified for default, prometheus, and pyo3 features; full test suite passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches all
opentelemetry/opentelemetry_sdk/opentelemetry-protodependencies from the pinned git rev (284a37d9) to their published crates.io releases. This clears the standing Dependabot alert foropentelemetry_sdk, which was a false positive: we were already on the patched0.32.1, but sourcing it from git meant Dependabot couldn't match it against its advisory database.Why this is safe
opentelemetry0.32.0,opentelemetry_sdk0.32.1,opentelemetry-proto0.32.0.AtomicU64/portable-atomicfix (open-telemetry/opentelemetry-rust#3345, merged 2026-02-06) — is already included in the publishedopentelemetry_sdk0.32.1 (confirmed: it carries theportable-atomicdependency). So the pin is no longer needed.Changes
Cargo.toml,utilities/,rotel_python_processor_sdk/,rotel_rust_processor_sdk/: git rev → registry versions.prometheusfeature's fork (mheffner/opentelemetry-prometheus-text-exporter, branchsorted-otel-0.32.1) was the last thing dragging a git-sourcedopentelemetry_sdkintoCargo.lock. It was updated to registry deps and the lock bumped to the new commit (bbeebcf).opentelemetry*packages remain inCargo.lock.Verification
--features prometheus,--features pyo3.After merge, Dependabot's next scan should clear the
opentelemetry_sdkalert.