Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage ? 88.03%
=======================================
Files ? 49
Lines ? 3243
Branches ? 544
=======================================
Hits ? 2855
Misses ? 231
Partials ? 157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoOkuma
approved these changes
Aug 22, 2025
| tracks_graph = rx.PyDiGraph(node_count_hint=n_tracks, edge_count_hint=n_tracks) | ||
| tracks_graph.add_nodes_from([None] * (n_tracks + 1)) | ||
|
|
||
| tracks_graph.add_node(0) |
Member
There was a problem hiding this comment.
@yfukai, what do you think of removing the node 0 now that you have improved it so it can take arbitrary track_ids?
Suggested change
| tracks_graph.add_node(0) |
This might require a minor update to the tests.
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Contributor
Author
|
@JoOkuma Hi sorry yesterday I didn't have time to update the tests. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
track_id_offsetinassign_track_idsseems to make the test fail. This PR intends to fix this issue.