Removing the "Null" node from assign_track_ids.#153
Merged
JoOkuma merged 1 commit intoroyerlab:mainfrom Sep 9, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 88.03% 88.03% -0.01%
==========================================
Files 49 49
Lines 3243 3242 -1
Branches 544 544
==========================================
- Hits 2855 2854 -1
Misses 231 231
Partials 157 157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoOkuma
approved these changes
Sep 8, 2025
Member
|
Thanks, @yfukai. |
Contributor
Author
|
Hi @JoOkuma, thanks for the review! It seems that I don't have the right to merge, but I've also double-checked this, and I believe it is good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #150, removing the "0" node from the track graph in
assign_track_idsand updating relevant pieces of the code.