Skip to content

Removing the "Null" node from assign_track_ids.#153

Merged
JoOkuma merged 1 commit intoroyerlab:mainfrom
yfukai:remove_null_node_from_tracks_graph
Sep 9, 2025
Merged

Removing the "Null" node from assign_track_ids.#153
JoOkuma merged 1 commit intoroyerlab:mainfrom
yfukai:remove_null_node_from_tracks_graph

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Aug 24, 2025

This is a follow-up PR for #150, removing the "0" node from the track graph in assign_track_ids and updating relevant pieces of the code.

@yfukai yfukai marked this pull request as ready for review August 24, 2025 05:33
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.03%. Comparing base (58cdd0d) to head (5fd9f0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   88.03%   88.03%   -0.01%     
==========================================
  Files          49       49              
  Lines        3243     3242       -1     
  Branches      544      544              
==========================================
- Hits         2855     2854       -1     
  Misses        231      231              
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoOkuma
Copy link
Copy Markdown
Member

JoOkuma commented Sep 8, 2025

Thanks, @yfukai.
LGTM, feel free to merge it.

@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Sep 8, 2025

Hi @JoOkuma, thanks for the review! It seems that I don't have the right to merge, but I've also double-checked this, and I believe it is good to go!

@JoOkuma JoOkuma merged commit 056cabe into royerlab:main Sep 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants