Skip to content

Conversation

@JoOkuma
Copy link
Member

@JoOkuma JoOkuma commented Jun 5, 2025

This PR includes the content of #9 and it can be closed once this is merged.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 82.25108% with 41 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (f624781) to head (d8798d7).

Files with missing lines Patch % Lines
src/tracksdata/graph/_graph_view.py 80.19% 12 Missing and 8 partials ⚠️
src/tracksdata/functional/_napari.py 0.00% 18 Missing ⚠️
src/tracksdata/graph/_rustworkx_graph.py 95.23% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   94.35%   91.81%   -2.55%     
==========================================
  Files          22       25       +3     
  Lines         638      733      +95     
  Branches      106      121      +15     
==========================================
+ Hits          602      673      +71     
- Misses         21       43      +22     
- Partials       15       17       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     454±4ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000    4.57±0.02s 
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   48.7±0.02s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points            153±1ns

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraph.time_points--).
[75.00%] ··· graph_backends.GraphSuite.time_simple_workflow                  ok
[75.00%] ··· ================================================== ========= =========
                                  backend                        n_nodes           
             -------------------------------------------------- --------- ---------
              tracksdata.graph._rustworkx_graph.RustWorkXGraph     1000    458±4ms 
              tracksdata.graph._rustworkx_graph.RustWorkXGraph    10000    4.58±0s 
              tracksdata.graph._rustworkx_graph.RustWorkXGraph    100000   49.4±0s 
             ================================================== ========= =========

[100.00%] ··· graph_backends.RustWorkXGraph.time_points                  148±3ns

@JoOkuma JoOkuma merged commit f0b16b8 into main Jun 5, 2025
5 checks passed
@JoOkuma JoOkuma deleted the jookuma/graph-view branch June 5, 2025 21:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraph.time_points--).
[75.00%] ··· graph_backends.GraphSuite.time_simple_workflow                  ok
[75.00%] ··· ================================================== ========= ============
                                  backend                        n_nodes              
             -------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraph     1000     459±4ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraph    10000    4.57±0.01s 
              tracksdata.graph._rustworkx_graph.RustWorkXGraph    100000   48.6±0.06s 
             ================================================== ========= ============

[100.00%] ··· graph_backends.RustWorkXGraph.time_points                153±0.7ns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants