Skip to content

Conversation

@JoOkuma
Copy link
Member

@JoOkuma JoOkuma commented May 27, 2025

There is a bug in the subgraph and node mapping that needs to be fixed.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

Attention: Patch coverage is 60.27397% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (f624781) to head (fde7e45).

Files with missing lines Patch % Lines
src/tracksdata/graph/_rustworkx_graph.py 40.00% 11 Missing and 4 partials ⚠️
src/tracksdata/functional/_napari.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   94.35%   90.93%   -3.43%     
==========================================
  Files          22       24       +2     
  Lines         638      706      +68     
  Branches      106      118      +12     
==========================================
+ Hits          602      642      +40     
- Misses         21       46      +25     
- Partials       15       18       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     540±3ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000     5.41±0s   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   57.7±0.07s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points          158±0.3ns

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     549±2ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000    5.51±0.02s 
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   58.9±0.01s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points          159±0.7ns

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     530±6ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000    5.26±0.01s 
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   56.0±0.02s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points            154±2ns

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     481±6ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000     4.75±0s   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   50.7±0.05s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points            149±2ns

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     476±1ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000    4.78±0.01s 
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   51.0±0.03s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points          157±0.3ns

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[ 0.00%] ·· Benchmarking existing-py_home_runner_work_tracksdata_tracksdata_.venv_bin_python3
[25.00%] ··· Running (graph_backends.GraphBackendSuite.time_simple_workflow--).
[50.00%] ··· Running (graph_backends.RustWorkXGraphBackend.time_points--).
[75.00%] ··· ...kends.GraphBackendSuite.time_simple_workflow                 ok
[75.00%] ··· ========================================================= ========= ============
                                      backend                           n_nodes              
             --------------------------------------------------------- --------- ------------
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend     1000     484±3ms   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    10000     4.79±0s   
              tracksdata.graph._rustworkx_graph.RustWorkXGraphBackend    100000   51.1±0.04s 
             ========================================================= ========= ============

[100.00%] ··· ...h_backends.RustWorkXGraphBackend.time_points          145±0.4ns

@JoOkuma JoOkuma closed this pull request by merging all changes into main in f0b16b8 Jun 5, 2025
@JoOkuma JoOkuma deleted the jookuma/graph-track-id branch June 5, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants