Conversation
Agent-Logs-Url: https://github.com/rrobetti/JSqlParser/sessions/1a91a42d-ed37-490e-88b9-25c45e621b64 Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rrobetti
April 11, 2026 16:13
View session
rrobetti
reviewed
Apr 11, 2026
rrobetti
requested changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSqlParser failed to parse
FOR UPDATE OF t1, t2, t3(only single table was supported) andFOR UPDATE OF t ORDER BY col(non-standard but valid Oracle ordering). Both causedParseExceptionat the grammar level.Changes
New
ForUpdateClauseclassContainer for the full FOR UPDATE state — mode, table list, wait options — surfaced via
getForUpdate()onPlainSelect:Grammar fix: multi-table
OFclauseFOR UPDATE OF t1, t2, t3now parses correctly.Select.forUpdateTable: Tablereplaced withforUpdateTables: List<Table>;getForUpdateTable()is retained as a backward-compatible alias returning the first element.Grammar fix:
ORDER BYafterFOR UPDATEAdded optional
ORDER BYproduction inside the FOR UPDATE grammar block. AforUpdateBeforeOrderByflag preserves the original clause ordering intoString()/ deparser output so round-trip fidelity is maintained.Updated deparsers & validators
SelectDeParserandSelectValidatorupdated to iterate the full table list.Oracle test coverage
for_update07.sql(multi-table OF) andfor_update08.sql(ORDER BY after FOR UPDATE) are now inSpecialOracleTest.EXPECTED_SUCCESSES.