Validate public real-data pipelines#63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The existing Autzen smoke selected a corner XY region plus a narrow Z slice. On the live dataset it returned zero points, but the test still passed because it only compared the empty ROI against a full download. The new central XY query requires
0 < roi_count < header_point_count.Observed real-data results
E285D415641E0D9DE695B611DB874CC8FE995E8089B77A50D6056D24D8CBCC58Validation
python bench/public_copc/run.pypython bench/public_copc/run.py --http.venv/Scripts/python.exe bench/public_copc/validate_python.pycargo test -p spatialrust --features mvp --test mvp_public_copc --release -- --nocapture mvp_public_pcd_copc_bounds_resolution_and_pipelinecargo test -p spatialrust --features mvp,mvp-http --test mvp_public_copc --release -- --ignored --nocapture mvp_http_autzen_copc_bounds_smokecargo clippy -p spatialrust --features mvp,mvp-http --test mvp_public_copc -- -D warningscargo clippy --workspace --all-targets -- -D warningsRUSTFLAGS="-D warnings" cargo test --workspace --no-run