Merged
Conversation
This was
linked to
issues
May 4, 2025
Closed
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version to 0.9.0 and introduces a suite of new CLI tools (scopy, smove, sdiff, sfind, stree, and lss) along with comprehensive tests and added function type hints. Key changes include support for piping input to lss, enhanced type annotations across the codebase, and several improvements and new commands in the pyseq package.
Reviewed Changes
Copilot reviewed 34 out of 37 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/* | New unit tests for scopy, pyseq, lss, config, and other CLI tools |
| lib/pyseq/*.py | Added type hints and minor refactorings in several modules (seq, util, scopy, smove, sdiff, lss, config, etc.) |
| setup.py & README.md | Updated console entry points and documentation samples |
Files not reviewed (3)
- CHANGELOG: Language not supported
- dist.json: Language not supported
- pyseq.env: Language not supported
Comments suppressed due to low confidence (2)
lib/pyseq/config.py:56
- [nitpick] Consider refactoring the use of global variables in set_frame_pattern to reduce potential side effects, especially in multithreaded or complex environments.
frames_re = re.compile(PYSEQ_FRAME_PATTERN)
lib/pyseq/seq.py:444
- [nitpick] The setslice method is deprecated in Python 3; consider removing it and handling slicing exclusively through setitem.
def __setslice__(self, start: int, end: int, item: Union[Item, str, List[str]]):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.9.0 RC
pyseq.uncompress()does not work with filenames containing whitespaces #86