Introduce .rspec config and drop RUBYOPT=-w from CI workflows#294
Merged
Conversation
Mirror the `.rspec` from rsim/oracle-enhanced:
--force-color
--backtrace
--require spec_helper
--warnings
The `--warnings` flag replaces the per-workflow `RUBYOPT=-w` prefix on
`bundle exec rspec`, so the same warning surface is now driven from a
single project-level file rather than seven workflow scripts plus one
workflow-level env block in devcontainer.yml. `--force-color` and
`--backtrace` make CI logs (and local runs) more debuggable;
`--require spec_helper` lets individual specs skip the require eventually.
No spec changes; spec/plsql/procedure_spec.rb stays green
(195 examples, 0 failures, 1 pre-existing pending) and no new warnings
are emitted with `--warnings` on.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
yahonda
added a commit
that referenced
this pull request
May 13, 2026
The project-level .rspec (added in #294) sets `--require spec_helper`, so each spec file's explicit `require "spec_helper"` is now redundant. Remove the require line and the trailing blank line from all 11 spec files under spec/plsql/. Net change: -22 LOC. No behavior change. Full suite is green (468 examples, 0 failures, 1 pre-existing pending). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the
.rspecfrom rsim/oracle-enhanced:The
--warningsflag replaces the per-workflowRUBYOPT=-wprefix onbundle exec rspec, so the same warning surface is now driven from a single project-level file rather than seven workflow scripts plus one workflow-level env block indevcontainer.yml.--force-colorkeeps RSpec output colored when piped through CI log capture--backtraceshows full backtraces on failure--require spec_helperlets future spec files skip the explicit require (existingrequire "spec_helper"lines remain — they are now redundant but harmless, and cleaning them up is out of scope here)--warningsis equivalent toRUBYOPT=-wfor the rspec processFiles changed
.rspec(new).github/workflows/test.yml.github/workflows/test_11g.yml.github/workflows/test_11g_ojdbc11.yml.github/workflows/test_gemfiles.yml.github/workflows/ruby_head.yml.github/workflows/jruby_head.yml.github/workflows/truffleruby.yml.github/workflows/devcontainer.yml(drops the workflow-levelenv: RUBYOPT: "-w"block;bundle exec rake specpicks up.rspecviaRSpec::Core::RakeTask)Diff stat: 9 files changed, 11 insertions(+), 10 deletions(-)
Test plan
bundle exec rspec spec/plsql/procedure_spec.rb— 195 examples, 0 failures, 1 pre-existing pendingbundle exec rspec spec/plsql/version_spec.rb spec/plsql/sequence_spec.rb— confirms.rspecis picked up locally (ANSI color appears in piped output →--force-coloractive)--warnings🤖 Generated with Claude Code