Drop redundant require "spec_helper" from spec files#298
Merged
Conversation
The project-level .rspec (added in rsim#294) sets `--require spec_helper`, so each spec file's explicit `require "spec_helper"` is now redundant. Remove the require line and the trailing blank line from all 11 spec files under spec/plsql/. Net change: -22 LOC. No behavior change. Full suite is green (468 examples, 0 failures, 1 pre-existing pending). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The project-level
.rspecintroduced in #294 contains--require spec_helper, which makes RSpec auto-loadspec/spec_helper.rbbefore any example file. The explicitrequire "spec_helper"at the top of eachspec/plsql/*.rbis therefore redundant.Remove the require line plus the immediately-following blank line from all 11 files under
spec/plsql/:The
# encoding: utf-8magic comment that appears at the top of three files (connection_spec.rb, procedure_spec.rb, variable_spec.rb) is intentionally left alone — out of scope here.Diff stat: 11 files changed, 22 deletions(-).
Test plan
bundle exec rspec— 468 examples, 0 failures, 1 pre-existing pending (the Oracle 9.2 indexed-by-binary-integer skip). Confirms--require spec_helperfrom.rspeccontinues to load the helper before each example file.require "spec_helper"lines underspec/plsql/🤖 Generated with Claude Code