chore(infra): tighten rstack-skill-evaluator conventions#55
Merged
Conversation
- Track skills-test/<name>/report.md in git (was silently dropped by the existing skills-test/**/* ignore rule) - Drop duplicate skills-test/migrate-to-rsbuild/eval.json; evals/evals.json is the canonical layout per skill-creator - Rewrite rstack-skill-evaluator SKILL.md to defer to skill-creator for workflow/schema details and only pin repo-specific conventions - Remove orphaned cspell directive in migrate-to-rsbuild/report.md (cspell now ignores skills-test/**)
Pre-existing formatting drift from #54 picked up by `prettier -c .` in CI. Whitespace-only — column padding tightened in two markdown tables.
SoonIter
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #49 fixing a few rough edges in the
rstack-skill-evaluatorskill and itsskills-test/artifacts.skills-test/<name>/report.mdin git — the existingskills-test/**/*ignore rule was silently dropping it, so future skill reports would have been ignored on add.skills-test/migrate-to-rsbuild/eval.json.evals/evals.jsonis the canonical layout perskill-creator's schema; the singular top-level file was a leftover from an earlier iteration.dev-skills/rstack-skill-evaluator/SKILL.mdto defer toskill-creatorfor workflow / JSON schemas / grading details, and only pin repo-specific conventions (where artifacts go, what gets committed, whatreport.mdshould cover). Drops the unclear non-Claude-Code CLI sentence and the/tmpfixture path prescription.<!-- cspell:disable-next-line -->inmigrate-to-rsbuild/report.md—cspell.config.cjsalready ignoresskills-test/**, so the inline directive is dead.Also confirmed (no diff): listing
skill-creatorat the top level ofskills.jsonis required, not redundant —skills-package-managerdoes not walkmetadata.dependenciesrecursively.Test plan
git check-ignore -vconfirmsskills-test/<name>/report.mdandskills-test/<name>/evals/evals.jsonare now trackable, while non-canonical paths (e.g. workspace dirs, top-leveleval.json) stay ignoredeval.jsonunderskills-test/pnpm lintpasses