chore(infra): migrate plugins to Rstack CLI - #31
Merged
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (70)
📝 WalkthroughWalkthroughThe repository migrates package builds, documentation builds, linting, testing, and CI workflows to Rstack tooling. Package metadata now uses explicit distribution paths, export maps, catalog dependencies, and published plugin imports. Shared E2E server management replaces manual process handling. Playwright coverage expands across plugin examples. Node.js, pnpm, TypeScript, workspace, and package template configuration are updated. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (1)
.github/workflows/test-Windows.yml (1)
23-26: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winCheckout steps in both OS workflows persist credentials by default.
actions/checkoutkeeps the GitHub token in the local git config unlesspersist-credentials: falseis set. Both workflows run lint, build, and test commands against dependency code after checkout, so disabling persistence reduces the credential's exposure window as defense-in-depth, even though the job token is already scoped tocontents: read.
.github/workflows/test-Windows.yml#L23-L26: addpersist-credentials: falseto theactions/checkoutstep..github/workflows/test-macOS.yml#L23-L26: addpersist-credentials: falseto theactions/checkoutstep.🛠️ Proposed fix (apply to both files)
- name: Checkout uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: fetch-depth: 1 + persist-credentials: false🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/test-Windows.yml around lines 23 - 26, Update the actions/checkout step in .github/workflows/test-Windows.yml (lines 23-26) and .github/workflows/test-macOS.yml (lines 23-26) to set persist-credentials to false, leaving the existing checkout configuration unchanged.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/utils.ts`:
- Around line 74-89: Update the waitForServer rejection handler in runDevCommand
to terminate childProcess before rejecting, ensuring startup failures clean up
the spawned process even when useRstackDocServer has not assigned devProcess
yet. Apply the same cleanup behavior to the corresponding startup path around
the later referenced block.
In `@packages/rspress-plugin-align-image/rspress.config.ts`:
- Line 3: Make the in-workspace imports resolve during clean type checking:
update the TypeScript path/package resolution or lint build order for
packages/rspress-plugin-align-image/rspress.config.ts and
packages/rspress-plugin-back-to-top/rspress.config.ts so their package names
resolve to source files or generated dist entrypoints before rs lint
--type-check runs; apply the same resolution fix to both sites.
In `@packages/rspress-plugin-devkit/rspress.config.ts`:
- Around line 3-13: Update the import of
RemarkCodeBlockToGlobalComponentPluginFactory in rspress.config.ts to reference
the package’s source index export instead of the package root, ensuring CI
resolves the factory before distribution build output is available and preserves
strict-safe typing for propsProvider.
In `@packages/rspress-plugin-file-tree/package.json`:
- Around line 43-55: Add the package’s own workspace package as a devDependency
in packages/rspress-plugin-file-tree/package.json, and apply the same
self-referencing dependency fix in
packages/rspress-plugin-gh-pages/package.json. Ensure the build runs before
type-checking the published-name imports in
packages/rspress-plugin-file-tree/rspress.config.ts and
packages/rspress-plugin-gh-pages/rspress.config.ts; those config files require
no direct change.
In `@packages/rspress-plugin-google-analytics/rspress.config.ts`:
- Around line 3-11: Make the self-package import in rspress.config.ts resolvable
before the package is built by configuring the development typecheck path to
target the package’s src/index.ts, or ensure the package build generates
dist/index.d.ts before this config is checked. Update the relevant package or
workspace TypeScript/build configuration while preserving the existing
rspress-plugin-google-analytics import.
In `@packages/rspress-plugin-katex/rspress.config.ts`:
- Line 3: Resolve the local plugin self-imports before documentation
configuration typechecking by using a resolvable source entry or adding an
appropriate source export condition. Apply the same fix to the imports in
packages/rspress-plugin-katex/rspress.config.ts:3-3,
packages/rspress-plugin-live2d/rspress.config.ts:3-3, and
packages/rspress-plugin-mermaid/rspress.config.ts:3-3 so Rstack and TypeScript
resolve each plugin before its built exports and declarations exist.
In `@packages/rspress-plugin-reading-time/rspress.config.ts`:
- Line 3: Make the self-references for rspress-plugin-reading-time,
rspress-plugin-supersub, and rspress-plugin-vercel-analytics resolvable during
docs type checks by adding appropriate source mappings in each package
manifest/exports, or ensure rs lib runs before config validation. Apply the
change at packages/rspress-plugin-reading-time/rspress.config.ts:3,
packages/rspress-plugin-supersub/rspress.config.ts:3, and
packages/rspress-plugin-vercel-analytics/rspress.config.ts:3; all three sites
require the same resolution fix.
In `@rstack.config.ts`:
- Around line 28-33: Remove the global '`@typescript-eslint/no-explicit-any`':
'off' entry from the rules configuration in rstack.config.ts so the
repository-wide lint command enforces the strict-safe TypeScript guideline. If
an exception is required, scope it to only the specific files or patterns that
genuinely need it rather than disabling the rule for all packages.
In `@tsconfig.base.json`:
- Around line 3-7: Enable full TypeScript strict mode by adding "strict": true
to the shared compiler options in tsconfig.base.json, alongside the existing
target and module settings. Review every tsconfig that extends this base
configuration and resolve any type-checking issues introduced by the stricter
checks.
---
Nitpick comments:
In @.github/workflows/test-Windows.yml:
- Around line 23-26: Update the actions/checkout step in
.github/workflows/test-Windows.yml (lines 23-26) and
.github/workflows/test-macOS.yml (lines 23-26) to set persist-credentials to
false, leaving the existing checkout configuration unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d81d423d-b4a7-419b-a487-86caa4523e30
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.changeset/config.json.github/workflows/test-Windows.yml.github/workflows/test-macOS.yml.gitignore.node-version.npmrc.prettierignoreAGENTS.mde2e/utils.tspackage.jsonpackages/rspress-plugin-align-image/index.spec.tspackages/rspress-plugin-align-image/package.jsonpackages/rspress-plugin-align-image/rspress.config.tspackages/rspress-plugin-align-image/rstack.config.tspackages/rspress-plugin-back-to-top/index.spec.tspackages/rspress-plugin-back-to-top/package.jsonpackages/rspress-plugin-back-to-top/rspress.config.tspackages/rspress-plugin-back-to-top/rstack.config.tspackages/rspress-plugin-back-to-top/src/index.tspackages/rspress-plugin-devkit/components/DevkitCode.tsxpackages/rspress-plugin-devkit/docs/index.mdpackages/rspress-plugin-devkit/index.spec.tspackages/rspress-plugin-devkit/package.jsonpackages/rspress-plugin-devkit/rslib.config.tspackages/rspress-plugin-devkit/rspress.config.tspackages/rspress-plugin-devkit/rstack.config.tspackages/rspress-plugin-devkit/src/NodeFactory/ESTreeNodeFactory.tspackages/rspress-plugin-directives/components/Oops.tsxpackages/rspress-plugin-directives/index.spec.tspackages/rspress-plugin-directives/package.jsonpackages/rspress-plugin-directives/rspress.config.tspackages/rspress-plugin-directives/rstack.config.tspackages/rspress-plugin-file-tree/index.spec.tspackages/rspress-plugin-file-tree/package.jsonpackages/rspress-plugin-file-tree/rspress.config.tspackages/rspress-plugin-file-tree/rstack.config.tspackages/rspress-plugin-file-tree/tests/esmImport.test.tspackages/rspress-plugin-file-tree/tests/parser.test.tspackages/rspress-plugin-gh-pages/index.spec.tspackages/rspress-plugin-gh-pages/package.jsonpackages/rspress-plugin-gh-pages/rspress.config.tspackages/rspress-plugin-gh-pages/rstack.config.tspackages/rspress-plugin-google-analytics/index.spec.tspackages/rspress-plugin-google-analytics/package.jsonpackages/rspress-plugin-google-analytics/rspress.config.tspackages/rspress-plugin-google-analytics/rstack.config.tspackages/rspress-plugin-katex/index.spec.tspackages/rspress-plugin-katex/package.jsonpackages/rspress-plugin-katex/rspress.config.tspackages/rspress-plugin-katex/rstack.config.tspackages/rspress-plugin-live2d/index.spec.tspackages/rspress-plugin-live2d/package.jsonpackages/rspress-plugin-live2d/rspress.config.tspackages/rspress-plugin-live2d/rstack.config.tspackages/rspress-plugin-mermaid/index.spec.tspackages/rspress-plugin-mermaid/package.jsonpackages/rspress-plugin-mermaid/rspress.config.tspackages/rspress-plugin-mermaid/rstack.config.tspackages/rspress-plugin-reading-time/components/ReadingTime.tsxpackages/rspress-plugin-reading-time/index.spec.tspackages/rspress-plugin-reading-time/package.jsonpackages/rspress-plugin-reading-time/rspress.config.tspackages/rspress-plugin-reading-time/rstack.config.tspackages/rspress-plugin-supersub/index.spec.tspackages/rspress-plugin-supersub/package.jsonpackages/rspress-plugin-supersub/rspress.config.tspackages/rspress-plugin-supersub/rstack.config.tspackages/rspress-plugin-vercel-analytics/index.spec.tspackages/rspress-plugin-vercel-analytics/package.jsonpackages/rspress-plugin-vercel-analytics/rspress.config.tspackages/rspress-plugin-vercel-analytics/rstack.config.tsplaywright.config.tspnpm-workspace.yamlrslint.config.tsrstack.config.tsrstest.config.tsscripts/rstack/lib.tstemplates/package.jsontemplates/rspress.config.tstemplates/rstack.config.tstsconfig.base.jsontsconfig.jsontypes/assets.d.ts
💤 Files with no reviewable changes (3)
- rstest.config.ts
- rslint.config.ts
- packages/rspress-plugin-devkit/rslib.config.ts
SoonIter
force-pushed
the
chore/repo-infrastructure-update
branch
from
July 31, 2026 09:55
9faddd4 to
e72974e
Compare
3 tasks
SoonIter
marked this pull request as draft
August 4, 2026 04:00
Member
Author
|
@codex review |
Member
Author
|
@coderabbitai review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
SoonIter
force-pushed
the
chore/repo-infrastructure-update
branch
from
August 4, 2026 07:30
2b59b11 to
4e1f13b
Compare
SoonIter
marked this pull request as ready for review
August 4, 2026 07:39
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e1f13b76f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7e689b5ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
SoonIter
force-pushed
the
chore/repo-infrastructure-update
branch
from
August 4, 2026 08:03
d8be77e to
4465c1b
Compare
SoonIter
force-pushed
the
chore/repo-infrastructure-update
branch
from
August 4, 2026 08:18
4465c1b to
0aafac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR standardizes all 13 plugin packages on shared Rstack CLI workflows for builds, docs, linting, tests, and Git hooks, while retaining package-specific Rslib configuration only where required.
It aligns CI and the workspace on Node.js 24.18.0, pnpm 11, Rslib v1, TypeScript 6, and the latest
@rspress/core2.0.19. The back-to-top package compiles its Less into published CSS so consumers do not need a Less plugin.Related Links