Skip to content

fix(setup): validate Git hooks directory - #104

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-setup-hooks-directory-validation
Jul 29, 2026
Merged

fix(setup): validate Git hooks directory#104
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-setup-hooks-directory-validation

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Invalid --hooks-dir values can produce unintended or mismatched Git hook targets. This PR normalizes hook directory separators and rejects empty or absolute paths before touching Git or the filesystem. It also covers the CLI exit status and diagnostics for both cases.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fc6e9804-4e22-48d3-bf1f-728790bd9e2b

📥 Commits

Reviewing files that changed from the base of the PR and between 95d6248 and 9140b03.

📒 Files selected for processing (2)
  • packages/rstack/src/setup/install.ts
  • packages/rstack/tests/cli/setup/index.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9140b03
Status: ✅  Deploy successful!
Preview URL: https://5a2063f6.rstack-cli.pages.dev
Branch Preview URL: https://chenjiahan-fix-setup-hooks-d.rstack-cli.pages.dev

View logs

@chenjiahan
chenjiahan merged commit d1259fe into main Jul 29, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-setup-hooks-directory-validation branch July 29, 2026 12:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9140b03361

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return fail('invalid-hooks-directory', 'Git hooks directory must not be empty.');
}

if (path.isAbsolute(resolvedDir)) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject drive-qualified Windows hook paths

On Windows, a drive-relative input such as --hooks-dir C:hooks is not considered absolute by path.isAbsolute, so it passes this validation even though it is not relative to cwd. The later path.join(cwd, resolvedDir, '_') produces a path containing C: as an interior component, causing setup to fail with a filesystem write-failed error instead of the intended invalid-directory diagnostic; reject paths with a drive root as well.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant