Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/rstack/src/fmt/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,12 @@ const logFmtResult = (
matchedFileCount: number,
durationSeconds: number,
): void => {
let writtenCount = 0;
let differentCount = 0;

for (const file of result.files) {
if (file.status === 'written') {
writtenCount++;
continue;
}

Expand All @@ -139,18 +141,17 @@ const logFmtResult = (
}

if (mode === 'write') {
if (result.exitCode !== 0) {
if (writtenCount === 0 && result.exitCode !== 0) {
return;
}

const writtenCount = result.files.length;
const matchedFiles = formatFileCount(matchedFileCount);
const time = prettyTime(durationSeconds);
if (writtenCount > 0) {
logger.success(`Formatted ${formatCount(writtenCount)} of ${matchedFiles} in ${time}.`);
} else {
logger.success(`Checked ${matchedFiles} in ${time}. No changes needed.`);
}
const message =
writtenCount > 0
? `Formatted ${formatCount(writtenCount)} of ${matchedFiles} in ${time}.`
: `Checked ${matchedFiles} in ${time}. No changes needed.`;
logger[result.exitCode === 0 ? 'success' : 'info'](message);
return;
}

Expand Down
13 changes: 13 additions & 0 deletions packages/rstack/tests/cli/fmt/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,19 @@ test('returns exit code 2 for formatting errors', () => {
expect(result.stderr).toContain('error index.ts: SyntaxError:');
});

test('reports partial writes when formatting fails', () => {
writeProjectFile('valid.ts', 'const value=true');
writeProjectFile('invalid.ts', 'const invalid = ;');

const result = runFmt(['valid.ts', 'invalid.ts']);

expect(result.status).toBe(2);
expect(normalizeDuration(result.stdout)).toBe('info Formatted 1 of 2 files in <duration>.\n');
expect(result.stderr).toContain('error invalid.ts: SyntaxError:');
expect(readProjectFile('valid.ts')).toBe('const value = true;\n');
expect(readProjectFile('invalid.ts')).toBe('const invalid = ;');
});

test('reports when no files match', () => {
const writeResult = runFmt(['missing/**/*.ts']);

Expand Down