feat(staged): allow unmatched rs fmt tasks - #188
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
9b1017a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97d1cffe.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-feat-staged-fmt-u.rstack-cli.pages.dev |
chenjiahan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rs stagedcan invoke anrs fmttask with only paths that the formatter ignores. This is currently treated as an unmatched invocation and fails the staged workflow, forcing users to add--no-error-on-unmatched-patternto otherwise valid configurations.This change marks child commands launched by
rs stagedand letsrs fmtexit successfully when no paths remain after matching and ignore filtering. Directrs fmtinvocations stay strict, while unsupported files and actual formatting errors continue to fail.