perf(fmt): reuse config options resolver - #210
Merged
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
e39ffa6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acfe8ec6.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-perf-fmt-config-o.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatter overrides currently resolve every file path relative to the config root with
path.relative. This PR creates one config options resolver per discovery run and reuses the shared root-path resolver across all files, while preserving the no-overrides and outside-root behavior.On rsbuild with one override,
path.relativecalls drop from 3,317 to 2 and discovery improves by about 6.1%; the no-overrides path remains unchanged.