Skip to content

feat(create-rstack): add i18n documentation template - #254

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-create-rstack-doc-i18n
Aug 8, 2026
Merged

feat(create-rstack): add i18n documentation template#254
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-create-rstack-doc-i18n

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

This PR adds a multilingual documentation starter for projects that need English and Chinese content from the start.

It adds a documentation language setup prompt, a doc-i18n template based on the existing simplified documentation starter, and focused generation coverage.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 742f3aa
Status: ✅  Deploy successful!
Preview URL: https://dc289911.rstack-cli.pages.dev
Branch Preview URL: https://chenjiahan-feat-create-rstac-7ac7.rstack-cli.pages.dev

View logs

@chenjiahan
chenjiahan merged commit 00fab61 into main Aug 8, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/feat-create-rstack-doc-i18n branch August 8, 2026 13:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 742f3aa2e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

title: 'My Site',
description: 'A multilingual Rspress documentation site.',
lang: 'en',
locales: [

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move locale definitions into themeConfig

When a generated doc-i18n project is served, Rspress reads the language definitions from themeConfig.locales, not the top-level locales property; the repository's working configuration demonstrates the required nesting in website/rstack.config.ts:60-93. As written, the new starter does not configure the language selector or localized site metadata, undermining its core multilingual behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant