Skip to content

fix: reload Rstack config without module cache#26

Merged
chenjiahan merged 2 commits into
mainfrom
chenjiahan/fix-fresh-config-loading
Jul 11, 2026
Merged

fix: reload Rstack config without module cache#26
chenjiahan merged 2 commits into
mainfrom
chenjiahan/fix-fresh-config-loading

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 11, 2026

Copy link
Copy Markdown
Member

This PR ensures repeated Rstack config loads re-evaluate the config instead of returning empty state from the ESM module cache. It enables fresh native loading and updates @rstackjs/load-config to v0.1.2 so config evaluation errors propagate without retrying.

Related Links

@chenjiahan chenjiahan force-pushed the chenjiahan/fix-fresh-config-loading branch from c7d614c to 451659a Compare July 11, 2026 08:50
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

loadRstackConfig now passes fresh: true to loadConfig. A new fixture registers an app during module loading. The load-state test verifies two successful loads of the fresh configuration, then switches to another configuration and expects loading to reject while preserving state cleanup.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: reloading Rstack config without using the module cache.
Description check ✅ Passed The description is directly related to the config reloading and fresh-loading changes in the PR.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/fix-fresh-config-loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan chenjiahan merged commit 56fecd5 into main Jul 11, 2026
4 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/fix-fresh-config-loading branch July 11, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant