Skip to content

docs: prefer rs check in migration skill #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Sep 2, 2026
Merged

docs: prefer rs check in migration skill #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .agents/skills/migrate-to-rstack-cli/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,19 @@ Read every matching reference before editing. Load only the tools present in the

Rsbuild, Rslib, Rstest, Rslint, and Prettier remain transitive `rstack` dependencies. Remove obsolete direct dependencies and imports from the migrated scope; do not expect their names to disappear from the lockfile.

### Combined checks

After migrating lint and formatting commands, prefer the shorter combined command when behavior is equivalent:

| Separate commands | Preferred command |
| ---------------------------------------- | ----------------------- |
| `rs lint && rs fmt --check` | `rs check` |
| `rs lint --type-check && rs fmt --check` | `rs check --type-check` |

`rs check` preserves the order and short-circuit behavior of these `&&` chains.

Combine only when both commands use the same working directory and Rstack config, with no positional inputs or command-specific options beyond those shown. Move a shared `-c` or `--config` to `rs check`. Keep the commands separate when their environment, wrappers, scope, execution order, concurrency, or output handling differs.

## Configuration

### Config files
Expand Down
9 changes: 6 additions & 3 deletions .agents/skills/migrate-to-rstack-cli/references/rslint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,20 @@ define.lint(({ globals }) => [

## Script pattern

If a script also runs Prettier, migrate its formatting command as described in [prettier.md](prettier.md).
For example:

```json
{
"scripts": {
"lint": "rs lint && rs fmt --check",
"lint:write": "rs lint --fix && rs fmt"
"check": "rs check",
"format": "rs fmt",
"lint": "rs lint"
}
}
```

Preserve existing script names unless renaming is requested. For scripts that also run Prettier, follow [prettier.md](prettier.md), then apply the [combined-check rules](../SKILL.md#combined-checks).

## Validate

Run lint without writes. If Rstack upgrades Rslint, preserve the pre-migration lint baseline: disable newly enabled rules instead of changing source code, unless code changes are requested.