test(vscode): harden startup-deadline E2E test against slow runners - #49
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
On a stalled Windows runner, more than 50ms could elapse between constructing the absolute deadline and
runBeforeDeadlinerecomputing the remaining time. The helper then rejected through its already-expired path without invoking the operation. The previous regex accepted both timeout paths, so the test failed later at theattempts === 1assertion instead of identifying the wrong rejection path.Verification
pnpm lint && pnpm test:unit— passed (165 linted files; 31 test files and 264 tests passed)VSCODE_CLI=1 pnpm test:e2e lint— passed (15/15 lint E2E suite launches exited successfully)Related Links
Checklist