Initial toolbar container #1263
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
…slib into feat/toolbar-container
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
…into feature/add-buttons
…into feature/add-buttons
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1259
To decide:
How will the width=auto work? If you have a single toolbar, should that split them to either side, essentially overriding the "align" parameter?
Should width=auto just supply a fixed width divider?
Maybe also make that divider line darker or thicker or both.
Standard Stuff
Add unit tests in the tests/testthat directory.
This project uses roxygen2 for documentation. If you've made changes to documentation, run
devtools::document().Run
devtools::check()(or, equivalently, click on Build->Check Package in the RStudio IDE) to make sure your change did not add any messages, warnings, or errors.Ensure your code changes follow the style outlined in http://r-pkgs.had.co.nz/style.html
Add an entry to NEWS.md concisely describing what you changed.