Skip to content

Split docs of value_box() and showcase_*() functions#1338

Merged
gadenbuie merged 7 commits into
rstudio:mainfrom
etiennebacher:split-card-and-showcase-args
Jul 17, 2026
Merged

Split docs of value_box() and showcase_*() functions#1338
gadenbuie merged 7 commits into
rstudio:mainfrom
etiennebacher:split-card-and-showcase-args

Conversation

@etiennebacher

@etiennebacher etiennebacher commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

This moves the three showcase_*() functions to their own page to improve the readability of value_box() docs. Technically, this change is visible to users but I'm not convinced it warrants a bullet point in NEWS.md. Let me know if you'd like me to add one.

Ping @gadenbuie

Fixes #1336

@CLAassistant

CLAassistant commented Jul 17, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gadenbuie
gadenbuie self-requested a review July 17, 2026 18:21
@gadenbuie

Copy link
Copy Markdown
Member

Thanks @etiennebacher! Looks good, but can you fix the R CMD check issues?

@etiennebacher

Copy link
Copy Markdown
Contributor Author

@gadenbuie those should be fixed now but apparently CI workflows don't run on every commit?

@gadenbuie gadenbuie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@gadenbuie
gadenbuie merged commit 3c0891b into rstudio:main Jul 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider splitting the docs of value_box() and showcase_*() functions?

3 participants