Respect cols_merge() + sub_*() with opt_interactive()#1786
Merged
rich-iannone merged 7 commits intorstudio:masterfrom Jul 15, 2024
Merged
Respect cols_merge() + sub_*() with opt_interactive()#1786rich-iannone merged 7 commits intorstudio:masterfrom
cols_merge() + sub_*() with opt_interactive()#1786rich-iannone merged 7 commits intorstudio:masterfrom
Conversation
cols_merge() with opt_interactive()`cols_merge() with opt_interactive()
cols_merge() with opt_interactive()cols_merge() + sub_*() with opt_interactive()
…. (and return early for a minimal performance gain
Member
|
Thank you @olivroy for getting to the bottom of this and resolving with the PR! Will merge this once CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Basically, this assumes that the first variable is always where the merge happened? Seems so, based on
Basically, the reason why the merged cells didn't show is because
extract_cells()was not run on newly created variavbles.Note that
dt_col_merge_get_vars()seems to properly returnNULLwhen no merge happens!I added substitution since the fix was very similar!
Related GitHub Issues and PRs
Fixes #1785, Fixes #1759 Fixes #1846
Checklist
testthatunit tests totests/testthatfor any new functionality.