Fix loading placeholder when question text is HTML#450
Merged
schloerke merged 4 commits intorstudio:masterfrom Jan 4, 2021
Merged
Fix loading placeholder when question text is HTML#450schloerke merged 4 commits intorstudio:masterfrom
schloerke merged 4 commits intorstudio:masterfrom
Conversation
Collaborator
|
LGTM! |
Fixes text for answers like `answer(2)`
Member
Author
|
I found another related case where a non-character and I added https://github.com/gadenbuie/learnr/blob/d94855cfd92327273909472e9c5e2f457d5fe73e/R/quiz.R#L227-L229 in |
schloerke
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
question()accepts HTML for thetextargument, in particular usinghtmltoolstags. But the default value of theloadingargument usesc()to concatenatec("Loading...", text), which results in an unusual list thatquiz_text()isn't expecting andmarkdown::renderMarkdown()throws an error.I just changed the default to
c("Loading", format(text))so that the shiny tags are formatted as a character.PR task list:
devtools::document()I'll add a NEWS item if the PR looks good to you.