fix: support reading type arrow #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on this comment #135 (comment) switching "arrow" to be the go-to type, deprecating "feather". |
machow
force-pushed
the
fix-compat-r-arrow
branch
from
d696a6e to
1bb364b
Compare
|
@juliasilge do you mind double checking this (either the code or sanity checking it does what we discussed!)? I set pins to...
This means users will be able to read R arrow pins, and we won't have to put redundant code in R pins for "feather" type pins. |
juliasilge
approved these changes
Jun 24, 2022
Co-authored-by: Julia Silge <julia.silge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #135