Skip to content

Conversation

@ConorIA
Copy link
Contributor

@ConorIA ConorIA commented Oct 21, 2020

As written, the authors block is never closed when there is no \currentaddress for author 2. I've also moved the closing $endif$ for $if(author1)$ so that we don't end up with a stray brace when no authors are specified.

As written, the authors block is never closed when there is no current address for author 2. I've also moved the closing $endif$ for $if(author1)$ so that we don't end up with a stray brace when no authors are specified.
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2020

CLA assistant check
All committers have signed the CLA.

@ConorIA ConorIA changed the title Fix brace in author2 AMS template.tex: Fix brace in author2 Oct 21, 2020
@cderv
Copy link
Collaborator

cderv commented Oct 21, 2020

Thanks !

This looks ok to me.

IMO, this part could be rewriten to use a for loop for authors like in other template. For example:

\author{
$for(authors)$
$authors.name$
$if(authors.thanks)$
\thanks{$authors.thanks$}
$endif$ \\
$if(authors.department)$
$authors.department$ \\
$endif$
$authors.affiliation$ \\
$authors.location$ \\
\texttt{$authors.email$} \\
$sep$ \And
$endfor$
}

Currently, there could only be two authors for example. But maybe that is required by the template, IDK.

ping @yufree as you are the one submitted this template in the first place. FYI.

@cderv cderv merged commit 5592c04 into rstudio:master Oct 21, 2020
@cderv
Copy link
Collaborator

cderv commented Oct 21, 2020

Thank you @ConorIA !

@yufree
Copy link
Contributor

yufree commented Oct 21, 2020

Thanks for PR!
author1 is for the old AMS latex template to deal with two authors situation. As mentioned in #298 , AMS has released v5 template which will no longer need author1. However, to make the rticle AMS template work, such change is necessary. In long term, rticle AMS template will shift to new version.

@cderv
Copy link
Collaborator

cderv commented Oct 21, 2020

Great ! I forgot about his PR!

@ConorIA ConorIA deleted the patch-1 branch October 21, 2020 16:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants