Refactor install tests - #1033
Merged
Merged
Conversation
Remove repo folders. Just store each config in a file for each repo or install method. * Makefile (install-all): Add install-melpa-releases target. * install-test/melpa-releases-emacs: New repo melpa/releases. * install-test/elpa-devel-emacs: install-test/elpa-emacs: install-test/elpaca-emacs: install-test/local-emacs: install-test/melpa-emacs: install-test/straight-emacs: install-test/tarball-emacs: Renamed and Removed Emacs 27 check. * install-test/local-install-test.sh: Use the renamed files. * install-test/tarball-install-local.sh: Renamed. * install-test/MANIFEST: Use the renamed files.
rswgnu
requested changes
Aug 7, 2026
|
|
||
| (require 'package) | ||
| (setq package-native-compile t) | ||
| (add-to-list 'package-archives '("melpa-releases" . "https://releases.melpa.org/packages/")) |
Owner
There was a problem hiding this comment.
If we are starting to use melpa-releases rather than melpa-stable, then the 'devel' option should be melpa-snapshots rather than the older melpa.
Collaborator
Author
There was a problem hiding this comment.
I just wanted to test how our Melpa release looked like so I added that as part of this refactoring. We have never tested "melpa stable" since it sort of was a discouraged repo from the start.
rswgnu
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove repo folders. Just store each config in a file for each repo or
install method.
Makefile (install-all): Add install-melpa-releases target.
install-test/melpa-releases-emacs: New repo melpa/releases.
install-test/elpa-devel-emacs:
install-test/elpa-emacs:
install-test/elpaca-emacs:
install-test/local-emacs:
install-test/melpa-emacs:
install-test/straight-emacs:
install-test/tarball-emacs: Renamed and Removed Emacs 27 check.
install-test/local-install-test.sh: Use the renamed files.
install-test/tarball-install-local.sh: Renamed.
install-test/MANIFEST: Use the renamed files.
Why
Using separate folders for each repo or install method was not really
needed and created an unnecessary directory structure.
Note
use-package
The recent use-package definitions are not include in this refactoring. I prefer to do that in a separate PR to separate out the refactoring from the potential install changes. Maybe we also want to add more tests than just that Hyperbole was successfully installed!?
Further possibilities
Makefile still has targets for each install method. An alternative
could be to use a parameter. There would be less targets in the
Makefile that way. Today it looks like this:
With using a parameter it would look like this: