Add Lint CI config #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShotaAk
reviewed
Jul 16, 2021
| - '.github/workflows/driver-cross-build.yml' | ||
|
|
||
| jobs: | ||
| build: |
Contributor
There was a problem hiding this comment.
Lintをワークフローではなくジョブにして、Lintが失敗したらクロスビルドをキャンセルするように変更するのはどうでしょうか？
Contributor
Author
There was a problem hiding this comment.
ShotaAk
approved these changes
Jul 19, 2021
Contributor
ShotaAk
left a comment
ShotaAk
left a comment
There was a problem hiding this comment.
lintのジョブ化ありがとうございます。動作良いと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
rtmouse.cのコメント内のバージョンとMODULE_VERSIONが一致しているかを確認しますDoes this close any currently open issues?
しません
How has this been tested?
本PR内で確認しています。
clang-format未適用のままpushする
https://github.com/rt-net/RaspberryPiMouse/runs/3006491277
rtmouse.cのコメント内のバージョンとMODULE_VERSIONが一致していない状態でpushするhttps://github.com/rt-net/RaspberryPiMouse/runs/3006508043
Any other comments?
Checklists