Test case for AMP_AdManager class #71
Conversation
rtBot
left a comment
rtBot
left a comment
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 17 errors
hashes-api-scanning skipped
Posting will continue in further review(s)
| /** | ||
| * This function sets the instance for class \AMP_AdManager\Shortcode. | ||
| */ | ||
| public function setUp(): void { |
There was a problem hiding this comment.
🚫 Error: void return type is not present in PHP version 7.0 or earlier (PHPCompatibility.FunctionDeclarations.NewReturnTypeDeclarations.voidFound).
| * | ||
| * @var AMP_AdManager | ||
| */ | ||
| protected $_instance; |
There was a problem hiding this comment.
| call_user_func( | ||
| sprintf( 'has_%s', $hook['type'] ), | ||
| $hook['name'], | ||
| array( |
There was a problem hiding this comment.
Use [] array syntax here
| * @param array $args WP query arguments. | ||
| * @param array $conditions wp query conditions. | ||
| */ | ||
| public function mock_wp_query( $args, $conditions ) { |
There was a problem hiding this comment.
Can we move this method to Utility class so it can be reused wherever needed
|
|
||
| // Update settings after updating option. | ||
| AMP_AdManager::$amp_settings = get_option( 'amp-admanager-menu-settings' ); | ||
| $output = Utility::buffer_and_return( array( $this->_instance, 'load_amp_resources' ) ); |
| ) ); | ||
| update_option( | ||
| 'amp-admanager-menu-settings', | ||
| array( |
| $user_mock = $this->factory->user->create_and_get( [ 'role' => 'administrator' ] ); | ||
| wp_set_current_user( $user_mock->ID ); | ||
| $_GET['amp_validate'] = true; | ||
| $output_user = Utility::buffer_and_return( array( $this->_instance, 'load_amp_resources' ) ); |
|
@vaishaliagola27 The AMP admanager class has some missing code coverage can you please fix it or ignore it with valid comments if it cannot be covered. |
rtBot
left a comment
rtBot
left a comment
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 3 errors
hashes-api-scanning skipped
Add test case for AMP_AdManager class
Covers point 3 in #60 (comment)