Speed up parser by making it synchronous - #676
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading files asynchronously is slower than reading them synchronously. Async mostly makes sense when you are writing a server that needs to respond to many different requests simultaneously. But that’s not our use case.
Inspired by elm-watch, this PR switches from
fs.createReadStreamtofs.readSyncwith a buffer that we reuse. This makes parsing go almost 2x faster.This also means that we no longer need the
graceful-fsdependency.Read the diff without whitespace changes since a few functions lost indentation.