Correct Flash-X attribution and add the requested citation - #1
Merged
Conversation
The acknowledgments stated that Flash-X is developed and maintained by the Flash Center for Computational Science. That conflates two distinct codes. Per Flash-X's own NOTICE file, copyright is held by UChicago Argonne, LLC as operator of Argonne National Laboratory, and the Flash Center is credited only as a source of derived software. Flash-X's README describes the code as derived from FLASH, and flash-x.org does not mention the Flash Center. FLASH itself continues to be maintained separately by the Flash Center, which relocated to the University of Rochester in 2021. Also add the citation that Flash-X requests in its CITATION.cff (Dubey et al., SoftwareX 19, 101168, 2022), which was previously absent, and note that this Docker environment is unaffiliated with the Flash-X project. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acknowledgments credited the Flash Center for Computational Science with developing and maintaining Flash-X. That conflates Flash-X with FLASH.
Evidence
NOTICE: copyright © 2021 UChicago Argonne, LLC as operator of Argonne National Laboratory. The Flash Center appears only as provenance — the product "includes software developed by and/or derived from" it.README: the code "is derived from FLASH."Also
Adds the citation Flash-X requests in
CITATION.cff(Dubey et al., SoftwareX 19, 101168, 2022), which was missing, plus a line clarifying that this Docker environment is unaffiliated with the Flash-X project.🤖 Generated with Claude Code