Simplify packaging (uv) + architecture; fix cost-report cache cost; add credential & precompact hooks#15
Merged
Conversation
…ated model of class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies agent-notes' packaging and architecture (the "Option A" direction — stay in Python, fix the real pain points) and lands three approved functional improvements. Every refactor is behavior-preserving:
agent-notes buildoutput stays byte-identical and the full suite is green at each step.Test status: 1810 passed (was 1579 at branch point — +231 new tests), generated
dist/byte-identical todevelop.Packaging — kills the venv friction
uv([dependency-groups]+uv.lock); de-venvscripts/releaseto uv-first with a.venvfallback; CI →astral-sh/setup-uv.tomli_wso it's no longer needed at CLI startup for unrelated commands.Architecture — phased, behavior-preserving
strip_sections/COLOR_TO_HEXextracted from the 3 generators.Role.default_modelis dead data (declared in YAML, never read).install_plan.py+install_executor.py; added build→install→doctor round-trip integration tests.Functional
cache_creation(5m/1h) tokens and prices read 0.1× / write-5m 1.25× / write-1h 2× of input. Previously cache writes were invisible; real transcripts use the 1h TTL, so spend was materially understated..env.exampleallowed, fail-closed for recognized tools.Roles, install/uninstall assurance, and docs (follow-up)
default_model— the field was only read by the wizard (never by resolution). Removed it; the wizard now selects the newest non-deprecated model of a role's class. This also wired upModel.deprecated(the flag was in the YAML but never loaded), so the wizard no longer offers deprecated models.reasonerstill resolves toclaude-opus-4-8; generated output unchanged.permissions.allowentry / state scope / component / context file is removed while user keys and intentionally-kept vault permissions survive; plus a full-wizard happy-path test.permissions.allowvault-permission note), an "Upgrade from a previous version" subsection (update-in-place vs clean reinstall one-liners), and a note thatuvis dev/release-only (end-user install stays pipx/venv).Deferred / out of scope
isolation: worktreedefault-on would change the direct-edit workflow.Role.default_model; consider anode_modulespath-allowlist for the credential guard.scripts/releaseis uv-first (no longer pinned to.venv).