Skip to content

Issue #5723 #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Issue #5723 #6029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc95d2e
Issue #5723
GmausDev Oct 12, 2022
0433ab4
Fix typo
GmausDev Oct 12, 2022
78e9382
Renamed all references
GmausDev Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ public enum CodeInspectionType
{
RubberduckOpportunities,
LanguageOpportunities,
MaintainabilityAndReadabilityIssues,
NamingAndConventionsIssues,
CodeQualityIssues,
Performance,
Uncategorized,
}
}
251 changes: 124 additions & 127 deletions Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs
View file
Open in desktop

Large diffs are not rendered by default.

38 changes: 19 additions & 19 deletions Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Value Profile="(Default)">&lt;?xml version="1.0" encoding="utf-16"?&gt;
&lt;CodeInspectionSettings xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"&gt;
&lt;CodeInspections&gt;
&lt;CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="StopKeywordInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="UnhandledOnErrorResumeNextInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
Expand All @@ -18,52 +18,52 @@
&lt;CodeInspection Name="AttributeOutOfSyncInspection" Severity="Warning" InspectionType="RubberduckOpportunities" /&gt;
&lt;CodeInspection Name="MissingAnnotationArgumentInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="RedundantOptionInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="OptionExplicitInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ProcedureCanBeWrittenAsFunctionInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ApplicationWorksheetFunctionInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="AssignedByValParameterInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="IntegerDataTypeInspection" Severity="Hint" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ShadowedDeclarationInspection" Severity="DoNotShow" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ConstantNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="ImplicitActiveSheetReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ImplicitActiveWorkbookReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ImplicitDefaultMemberAssignmentInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ImplicitPublicMemberInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ImplicitVariantReturnTypeInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="NonReturningFunctionInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ObsoleteGlobalInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="ParameterNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="SelfAssignedDeclarationInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="UnassignedVariableUsageInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="UndeclaredVariableInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="VariableNotAssignedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="VariableNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="VariableTypeNotDeclaredInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
Expand All @@ -72,7 +72,7 @@
&lt;CodeInspection Name="StepIsNotSpecifiedInspection" Severity="DoNotShow" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="StepOneIsRedundantInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
&lt;CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
&lt;CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
&lt;CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
&lt;CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error" InspectionType="RubberduckOpportunities" /&gt;
&lt;CodeInspection Name="ModuleWithoutFolderInspection" Severity="Suggestion" InspectionType="RubberduckOpportunities" /&gt;
Expand Down
38 changes: 19 additions & 19 deletions Rubberduck.CodeAnalysis/app.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<CodeInspections>
<CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="StopKeywordInspection" Severity="Suggestion"
Expand All @@ -46,16 +46,16 @@
<CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="MultilineParameterInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" />
<CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="RedundantOptionInspection" Severity="Hint"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="OptionExplicitInspection" Severity="Error"
Expand All @@ -67,7 +67,7 @@
<CodeInspection Name="AssignedByValParameterInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="EmptyModuleInspection" Severity="Hint"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="IntegerDataTypeInspection" Severity="Hint"
Expand All @@ -77,27 +77,27 @@
<CodeInspection Name="ConstantNotUsedInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyElseBlockInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyIfBlockInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="HungarianNotationInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="ImplicitActiveSheetReferenceInspection"
Severity="Warning" InspectionType="LanguageOpportunities" />
<CodeInspection Name="ImplicitActiveWorkbookReferenceInspection"
Expand All @@ -111,7 +111,7 @@
<CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="NonReturningFunctionInspection" Severity="Error"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error"
Expand All @@ -121,7 +121,7 @@
<CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="ParameterNotUsedInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning"
Expand All @@ -135,7 +135,7 @@
<CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="VariableNotAssignedInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="VariableNotUsedInspection" Severity="Warning"
Expand All @@ -153,7 +153,7 @@
<CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion"
InspectionType="LanguageOpportunities" />
<CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning"
InspectionType="MaintainabilityAndReadabilityIssues" />
InspectionType="NamingAndConventionsIssues" />
<CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning"
InspectionType="CodeQualityIssues" />
<CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error"
Expand Down
Loading