Skip to content

Issue #5723 #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2022
Merged

Issue #5723 #6029

merged 3 commits into from
Oct 26, 2022

Conversation

@GmausDev
Copy link
Contributor

@GmausDev GmausDev commented Oct 12, 2022

I´ve been added the required information. I hope its fine.

@rubberduck-vba-releasebot
Copy link
Member

rubberduck-vba-releasebot commented Oct 12, 2022

❌ Build Rubberduck 2.5.2.6146 failed (commit 267cdc9bc0 by @GmausDev)

@rubberduck-vba-releasebot
Copy link
Member

rubberduck-vba-releasebot commented Oct 12, 2022

❌ Build Rubberduck 2.5.2.6147 failed (commit ece997bbf0 by @GmausDev)

@retailcoder retailcoder added the hacktoberfest-accepted Thank you! Get that t-shirt! label Oct 12, 2022
@retailcoder retailcoder marked this pull request as draft October 12, 2022 23:48
@retailcoder
Copy link
Member

retailcoder commented Oct 12, 2022

I've converted this PR to "draft", since it's a work-in-progress - don't hesitate to ask any questions, we're very happy to help!

@GmausDev
Copy link
Contributor Author

GmausDev commented Oct 13, 2022

I renamed all the references, also added the undefined

@rubberduck-vba-releasebot
Copy link
Member

rubberduck-vba-releasebot commented Oct 13, 2022

✅ Build Rubberduck 2.5.2.6148 completed (commit c375f5584c by @GmausDev)

@GmausDev
Copy link
Contributor Author

GmausDev commented Oct 17, 2022

It´s okay?

@Vogel612
Copy link
Member

Vogel612 commented Oct 17, 2022

As it is, this is only a partial fix to the changes suggested in the original issue. As it is, this is perfectly ready to merge, though.

The current state does not include the proposed "new" inspection types or the configuration reader handling that sets the inspection types to use the introduced "Uncategorized" value.

I vote in favor of accepting this PR as is and leaving the reviewing (and recategorizing) to someone in the core team

@Vogel612 Vogel612 marked this pull request as ready for review October 17, 2022 21:28
@Vogel612 Vogel612 mentioned this pull request Oct 17, 2022
Closed
@retailcoder
Copy link
Member

retailcoder commented Oct 17, 2022

Absolutely no problem at all, no worries!

@retailcoder retailcoder merged commit 9716496 into rubberduck-vba:next Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vogel612 Vogel612 Vogel612 approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Thank you! Get that t-shirt!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GmausDev @rubberduck-vba-releasebot @retailcoder @Vogel612