Skip to content

Conversation

@bquorning
Copy link
Collaborator

@bquorning bquorning commented Apr 27, 2020

CircleCI recently added a feature for a workflow to configure a matrix of jobs to run. This allows us to remove a lot of duplicated configuration.

https://circleci.com/docs/2.0/configuration-reference/#matrix-requires-version-21


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the changelog if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning force-pushed the ci-matrix branch 2 times, most recently from b7f9de6 to 6d4a77e Compare April 27, 2020 20:27
CircleCI recently added a feature for a workflow to configure a matrix
of jobs to run. This allows us to remove a lot of duplicated
configuration.
@bquorning bquorning requested review from Darhazer and pirj April 27, 2020 20:46
@bquorning bquorning marked this pull request as ready for review April 27, 2020 20:51
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner now! 👍

@bquorning bquorning merged commit 03ce0a7 into master Apr 27, 2020
@bquorning bquorning deleted the ci-matrix branch April 27, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants