[FIx #10356] Add AllowConsecutiveConditionals option to Style/GuardClause

[ydah]

Resolve #10356

This PR add AllowConsecutiveConditionals option to Style/GuardClause and the option is false by default.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[bbatsov]

I'm fine with the proposal in principle, but I don't like very much the name of this variable. Something like AllowMultipleSameDepthConditionals sounds a bit better, even if it's longer. Naming is hard, maybe @rubocop/rubocop-core have better ideas.

[ydah]

My naming of variables was certainly not good. I think AllowMultipleSameDepthConditionals looks better.
I updated this PR.

[bbatsov]

Btw, there's one detail of this we need to clarify - do we want to apply it if there's any conditional at the same depth or only if the preceding expression is a conditional at the same depth. The implementation seems to imply the former, but at least to me it seems that that latter probably makes more sense. The OP (@johnnyshields) is welcome to share his thoughts as well.

[johnnyshields]

@bbatsov thanks for pinging me. I'm somewhat agnostic to either approach. I think I might favor it to be the "only if the preceding expression is a conditional at the same depth", but probably either is fine.

[ydah]

@bbatsov @johnnyshields Thanks so much for the feedback!
Certainly, I'd like "only if the preceding expression is a conditional at the same depth" is better.

I updated this PR. Thank you so much!

[bbatsov]

Good. Now that we've settled this I have a proposal how to simplify the config name further - "AllowConsecutiveConditionals". That's essentially the same as before, but a bit more specific and easier to parse mentally.

[johnnyshields]

@bbatsov yep perfect name its 100% clear.

[ydah]

@bbatsov Yeah perfect name! I updated this PR. Thank you so much!

[bbatsov]

Thanks for tackling this! 🙇‍♂️