Skip to content

Conversation

@dalzony
Copy link
Contributor

@dalzony dalzony commented Jul 30, 2014

Hello.
I add Korean version guide for Ruby community in Korea.

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 30, 2014

Nice! Just one question, though - why didn't you name the file README-koKO for consistency with the other translated versions?

@dalzony
Copy link
Contributor Author

dalzony commented Jul 30, 2014

Um..There is no special reason, I just only checked japanese version. (named README.ja.md)
I will change the file name README-koKo if you think that is better for consistency.

@dalzony
Copy link
Contributor Author

dalzony commented Aug 2, 2014

Hello, Please check this request again. (I modified file name to README-koKO)

bbatsov added a commit that referenced this pull request Aug 2, 2014
@bbatsov bbatsov merged commit 9f476f3 into rubocop:master Aug 2, 2014
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 2, 2014

Thanks!

@dalzony
Copy link
Contributor Author

dalzony commented Aug 2, 2014

👍 Thanks!

marocchino pushed a commit to marocchino/ruby-style-guide that referenced this pull request Aug 11, 2015
shyouhei pushed a commit to shyouhei/ruby-style-guide that referenced this pull request Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants